ho fatto qualche annotazione...fammi sapere


1)file conn.inc.php:
<?php
$HOSTNAME="mydb.mydomain";
$HOSTDB="MYDB";

$HOSTUSER="pippo";
$HOSTPWD="CANTERINO";
?>

2)file login.php:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<?php include("menu.php");
include('conn.inc.php');
?>
<title>Login</title>
</head>
<body>

<?php echo '<form name="formname" action="login.php" method="post">';
?>

#### mancano gli attributi value="" e il tag input non e chiuso
<form>
<p class="form">username :<input type="text" name="username"></p>

<p class="form">password :<input type="password" name="password"></p>

<input type="submit" value="invia">
</form>

<?php


#####vonviene che questo sia un altro file e non lo stesso a mio dire....
####e cmq inizi ad usare le variabili prima di averle riecvute

function authenticated($username, $password){


if (!isset($username) || !isset($password))
return false;

if ($username == '' && $password == ''){
echo "Empty Fields!
";
return false;
}

echo "

HOSTUSER: $HOSTUSER, </p>
";
echo "

HOSTPWD: $HOSTPWD, </p>
";
echo "

username: $username, </p>
";
echo "

password: $password, </p>
";

if ((strcmp($HOSTUSER, $username) == 0)
&&
strcmp($HOSTPWD, $password) == 0) {
echo "true!
";
return true;
}
else
### qui manca l'apertura della graffa
return false;
}
### solo ora effettui il post
if (!authenticated($_POST['username'],$_POST['password']))
{

header("WWW-Authenticate: Basic realm=\"Flat Foot\"");
header("HTTP/1.0 401 Unauthorized");
#### qui come mai riapri un altro documento?
?>
<!DOCTYPE HTML PUBLIC
"-//W3C//DTD HTML 4.0 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd" >
<html>
<head>
<title>Web Database Applications</title>
</head>
<body>
<h2>You need a username and password to
access this service</h2>


If you have lost or forgotten your
password, tough!
</body>
</html>
<?php

exit;
}

#### e qui un altro ancora?

?>
<!DOCTYPE HTML PUBLIC
"-//W3C//DTD HTML 4.0 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd" >
<html>
<head>
<title>Web Database Applications</title>
</head>
<body>
<h2>Welcome!</h2>
</body>
</html>


consiglio di dividere in piu pagine, e controllare attentamente il passaggio di parametri.....
se ho etto boiate scusa