semplificare script

[smile21]

ciao a tutti, tempo fa ho creato questo mostro di script, sicuramente lo si può alleggerire, ma leggendo nei forum e nelle guide non sono riuscita a capire se posso semplificarlo!!!

troppo ciorda!!!

se si come posso procedere?

<%
'---------------------------------------------------------------------------
' Il SQL sotto seleziona tutti i record del database clubs.
'---------------------------------------------------------------------------
msql = "SELECT * FROM [clubs] ORDER BY country"
Set RS=Conn.Execute(msql)
%>

<table border="1" cellpadding="3" cellspacing="0" align="Center" >


<%
Dim x
x = 0
Do While Not RS.EOF
x = x + 1
%>

<tr><td colspan="2" bgcolor="#EBEBEB">
<font size="2" color="#FF0000" face="Verdana"><%response.write (x)%> - <a href="updateasso.asp?record=<%=RS("ID")%>">
<%=RS("country")%></a> - <%=RS("federazione")%></font>

</td> </tr>

<tr>
<td colspan="2" ><font face="verdana" ><font size="1"><%=RS("indirizzo")%></font></font> -
<font face="verdana" ><font size="1"><%=RS("citta")%></font></font></td>

</tr>

<tr>
<td ><font face="verdana" ><font size="1"><%=RS("tel")%></font></font></td>
<td ><font face="verdana" ><font size="1"><%=RS("fax")%></font></font></td>
</tr>

<tr>
<td ><font face="verdana" ><font size="1"><%=RS("homepage")%></font></font></td>
<td ><font face="verdana" ><font size="1"><%=RS("email")%></font></font></td>

</tr>

<tr>

<td colspan="2" ><font face="verdana" ><font size="1"><%=RS("varie")%></font></font></td>

</tr>

<tr>
<td ><font face="verdana" ><font size="1"><%=RS("modif")%></font></font></td>

</tr>
<tr>


<td ><font face="verdana" ><font size="1"><%=RS("history")%></font></font></td>
<td ><font face="verdana" ><font size="1"><%=RS("media")%></font></font></td>
</tr>
<%

RS.MoveNext
Loop
RS.Close
Conn.Close
Set RS = Nothing
%>


<center><font size="4">back admin page</font></center>
</table>

<%

Else
If Request.ServerVariables("REQUEST_METHOD") = "POST" Then
'---------------------------------------------------------------------------
' Il SQL sotto Aggiorna il record dal database clubs.
'---------------------------------------------------------------------------
Conn.Execute ("UPDATE clubs SET clubs.country='" & Request.Form("country") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.federazione='" & Request.Form("federazione") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.indirizzo='" & Request.Form("indirizzo") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.citta='" & Request.Form("citta") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.tel='" & Request.Form("tel") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.fax='" & Request.Form("fax") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.media='" & Request.Form("media") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.homepage='" & Request.Form("homepage") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.email='" & Request.Form("email") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.varie='" & Request.Form("varie") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.modif='" & Request.Form("modif") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.history='" & Request.Form("history") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")

Conn.Close
Response.Write ("Associations updated.")
Else
msql = "SELECT * FROM [clubs] where clubs.ID=" & Request.QueryString("record")
Set RS = Conn.Execute(msql)
%>

<table border="0" cellpadding="3" cellspacing="0" align="Center" bordercolor="#FFFFFF" >
<Form Method="Post" Action='updateasso.asp?record=<%=Request.QueryStri ng("record")%>'>

<tr><td><font face="Verdana" size="2">Country</font></td><td><input type="text" name="country" value="<%=RS("country")%>" size="80"></td></tr>
<tr><td><font face="Verdana" size="2">Federation</font></td><td ><input type="text" name="federazione" value="<%=RS("federazione")%>" size="80"></td></tr>
<tr><td><font face="Verdana" size="2">Address</font></td><td ><input type="text" name="indirizzo" value="<%=RS("indirizzo")%>" size="80"></td></tr>
<tr><td><font face="Verdana" size="2">City</font></td><td ><input type="text" name="citta" value="<%=RS("citta")%>" size="80"></td></tr>
<tr><td><font face="Verdana" size="2">Tel</font></td><td ><input type="text" name="tel" value="<%=RS("tel")%>" size="80"></td></tr>
<tr><td><font face="Verdana" size="2">Fax</font></td><td ><input type="text" name="fax" value="<%=RS("fax")%>" size="80"></td></tr>
<tr><td><font face="Verdana" size="2">media</font></td><td ><input type="text" name="media" value="<%=RS("media")%>" size="80"></td></tr>

<tr><td><font face="Verdana" size="2">Home Page</font></td><td ><input type="text" name="homepage" value="<%=RS("homepage")%>" size="80"></td></tr>
<tr><td><font face="Verdana" size="2">Email</font></td> <td ><input type="text" name="email" value="<%=RS("email")%>" size="80"></td></tr>
<tr><td><font face="Verdana" size="2">Varie</font></td> <td ><textarea rows="3" name="varie" cols="41"><%=RS("varie")%></textarea></td></tr>
<tr><td><font face="Verdana" size="2">History</font></td><td ><input type="text" name="history" value="<%=RS("history")%>" size="80"></td></tr>
</tr>

<tr>

<td colspan="2" ><font face="Verdana" size="2">format date MUST BE: dd/mm/yyyy</font></td> </tr>
<tr>

<td ><font face="Verdana" size="2">last Modify</font></td><td><input type="text" name="modif" value="<%=formatDateTIME( DATE(), vbShortDate )%>" size="50"></td></tr>

<tr>
<td align="Center" colspan="2" width="347"><input type="submit" value="Update Record" name="B1"></td>
</tr>
</FORM>
</table>


<center><font size="4">UPDATED</font></center> <%End IF%>
<%End IF%>

</p>

</body>

</html>

[dwb]

Perchè vorresti semplificarlo?Ti causa problemi relativi al tempo di esecuzione o pecca di un'eccessivo utilizzo di risorse sul server?

[smile21]

ciao, ogni tanto lo riciclo per altri settori e mi capita che devo cambiare tutti i campi, ma la mia è solo pignoleria
ciao

[Ramboexp]

Questo

Conn.Execute ("UPDATE clubs SET clubs.country='" & Request.Form("country") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.federazione='" & Request.Form("federazione") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.indirizzo='" & Request.Form("indirizzo") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.citta='" & Request.Form("citta") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.tel='" & Request.Form("tel") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.fax='" & Request.Form("fax") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.media='" & Request.Form("media") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.homepage='" & Request.Form("homepage") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.email='" & Request.Form("email") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.varie='" & Request.Form("varie") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.modif='" & Request.Form("modif") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")
Conn.Execute ("UPDATE clubs SET clubs.history='" & Request.Form("history") & "' WHERE clubs.ID=" & Request.QueryString("record") & ";")

Con questo

record = Request.QueryString("record")
country = Request.Form("country") 
federazione = Request.Form("federazione")
indirizzo = Request.Form("indirizzo") 
citta = Request.Form("citta")
tel = Request.Form("tel")
fax = Request.Form("fax") 
media = Request.Form("media")
homepage = Request.Form("homepage")
email = Request.Form("email")
varie = Request.Form("varie")
modif = Request.Form("modif")
histoty = Request.Form("history") 

Conn.Execute ("UPDATE clubs SET clubs.country='" & country & "', clubs.federazione='" & federazione & "', clubs.indirizzo='" & indirizzo & "', clubs.citta='" & citta & "', clubs.tel='" & tel & "', clubs.fax='" & fax & "', clubs.media='" & media & "', clubs.homepage='" & homepage & "', clubs.email='" & email & "', clubs.varie='" & varie & "', clubs.modif='" & modif & "', clubs.histoty='" & histoty & "' WHERE clubs.ID=" & record & ";")

? prova